Skip to content

Feature/customiseble table creator #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Refael10ru
Copy link
Contributor

refactor to use iterators as asked in #415

make the table creator configurable
^ may need some advice on what is acceptable "API" for that

@Refael10ru
Copy link
Contributor Author

  • I would be glad if you know any good way to get rid of the code duplication of the Indexable implementation

Copy link
Contributor

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, some doc-comments for the functions would be nice though.

@tramhao tramhao merged commit c06293e into tramhao:master Feb 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants