ProtoBuf renames, type changes & use callbacks instead of static waiting #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate" and document it
…State" and document it
…_gapless" instead of calling the backend directly
even though it is already returned with the "ToggleGapless" function.
…stead of reference
call a callback after a event has been processed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the Protobuf situation a bit more, details:
u64(instead ofu32)GeneralPlayer::toggle_gaplessto call throughGeneralPlayer::set_Gapless(instead of on the backend directly)and finally, and biggest:
Refactor to optionally use callbacks for player events to use instead of static waiting
20ms. This makes it more reliable by not potentially reading old values and potentially being faster than 20ms.