0.4.0 #2
Merged
0.4.0 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It used to fail silently (client only displays error when a message is available).
The user password salt should be encoded with Base64 before being saved to the database. The current code adds an unecessary step of converting the result of crypto.randomBytes() (which already returns a SlowBuffer) to a Base64 string and back again to a Buffer, and misses the final step of converting the Buffer's bytes back to a Base64 string. Because of this, the salt stored in the database is garbled. This is inconvenient when manipulating the data in a terminal or text editor. When generating the password hash, the crypto.pbkdf2Sync() method creates a new Buffer directly from the data supplied. Due to the incorrect encoding of the salt, entropy is lost at this step, weakening the security of stored passwords against brute force attacks.
Currently createTransport is unnecessarily called upon every time a password request is made.
…ub.com/lirantal/meanjs into lirantal-enhancements-express-cookie-parameters Conflicts: config/env/all.js
…ress-cookie-parameters Enhancements express cookie parameters
Fixed two tiny typos.
… application startup
details on breaking changes: https://github.com/angular-ui/bootstrap/blob/eec68d81f4f72363d37493c495b 892347bdb9e1b/CHANGELOG.md Conflicts: bower.json
…h is replaced by new output
fix getToggleElement on dropdown by updating to angular-bootstrap 0.12.0 meanjs#250
Removed unneeded comas from gruntfile.
…tance Abstract nodemailer createTransport
Show error message when sending password request mail fails
Remove unecessary comment in karma.conf.js
Remove targets on signin and signup anchors
… object instead of just a connection string
…d from the merge of 0.4.0 into master
- remove access.log (*.log is enough) - Move local.js config under MEAN.JS - Rename iOS/Apple => OS (this is a mix of windows/osx stuff anyways)
Sort out gitignore
This reverts commit 7d8cea1.
update dependencies
Master to 0.4.0
Remove duplicate assets definition
Update package.json to indent space-2.
Add return for done(err) in test
trainerbill
pushed a commit
that referenced
this pull request
Jul 9, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.