Skip to content

feat: Add region boundary editing feature#124

Merged
fcasal merged 9 commits intomainfrom
edit-finding-boundary
Feb 13, 2026
Merged

feat: Add region boundary editing feature#124
fcasal merged 9 commits intomainfrom
edit-finding-boundary

Conversation

@fcasal
Copy link
Collaborator

@fcasal fcasal commented Dec 22, 2025

This PR introduces a feature that allows changing the boundary of a weAudit region using keybinds or a CodeLens interface.

image

Test Instructions for Reviewers

  • Reload VS Code with the extension installed or run it via F5.
  • Create a finding, place the cursor inside it, and press the boundary shortcuts (cmd/ctrl+shift+numpad7 etc.); Alternatively, start the editing session with "weAudit: Edit Finding Boundary" command
  • verify the region expands/shrinks even if you didn’t run “Edit Finding Boundary” first.
  • Use the CodeLens buttons or the keybinds for the commands

@fcasal fcasal requested a review from Vasco-jofra as a code owner December 22, 2025 12:27
@dguido dguido force-pushed the edit-finding-boundary branch from 7e74003 to b23d095 Compare January 21, 2026 23:05
dguido
dguido previously approved these changes Jan 21, 2026
Copy link
Member

@dguido dguido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Rebased on main and resolved conflicts (both versions of code kept - the GitHub issue command from main and the CodeLens feature from this PR).

What this PR adds

  • New CodeLens-based boundary editing UI for findings
  • 6 new boundary commands: expand up/down, shrink top/bottom, move up/down
  • Keyboard shortcuts using numpad keys (8/4/6/2 pattern)
  • Context-aware toggle with weAudit.boundaryEditing when clause
  • Visual decorations showing the editing region

Code Quality

  • Clean separation of concerns with FindingBoundaryCodeLensProvider class
  • Proper cleanup on editor/file changes
  • Type-safe command metadata
  • Good documentation/comments

Build Status

  • ✅ Compiles successfully
  • ✅ Lints with no errors (only existing warnings)

LGTM - ready to merge.

fcasal and others added 5 commits February 11, 2026 17:23
Track VS Code launch and tasks configuration so contributors
can debug and build the extension out of the box.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@fcasal fcasal merged commit b3e277e into main Feb 13, 2026
16 checks passed
@fcasal fcasal deleted the edit-finding-boundary branch February 13, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants