Add codegen policy #702
Merged
Add codegen policy #702
+154
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PappasBrent
force-pushed
the
add-codegen-policy
branch
from
51688c4 to
c4cc3bb
Compare
Add a policy class to bundle together various translation options such as how to handle missing return statements and whether to skip translating function bodies
Add a default codegen policy that returns the options supplied in a given `vast:cc::action_options` instance, regardless of the function decl passed to its method calls.
Add logic to skip emtting a function's body depending on the function generator's policy for it.
- Replace policy fields with policy class. - Add the function mk_policy() to create a shared pointer to a default policy instance.
Add comment explaining why if we skip emitting a function body, we must set that function's visibility to private. The reason is because the verifier would fail to verify the function otherwise.
Add default policy that does not skip global initializers.
xlauko
force-pushed
the
add-codegen-policy
branch
from
c4cc3bb to
ac82431
Compare
Cpp-Linter Report
|
xlauko
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
emit_strict_function_returnandmissing_return_policyinto a single virtual class,policy_base, with methods for obtaining these values on a per-functiondecl basis.skip_function_body, for controlling whether to emit the body of a given function decl.skip_global_initializer, for controlling whether to emit the body of a given var decl.default_policyclass to provide default policy options. It accepts avast::cc::action_options &instance in its constructor and defaults to returning the options' settings for all function decls.Addresses the first two checkboxes of #462