Skip to content

Conversation

Boyan-MILANOV
Copy link
Contributor

@Boyan-MILANOV Boyan-MILANOV commented Jul 19, 2022

This PR adds the following simplification patterns on constraints that we often encounter within MATE:

!(a||b) -> !a && !b
!(a&&b) -> !a || !b
a == True -> a
a == False -> !a
1*a -> a

@Boyan-MILANOV Boyan-MILANOV marked this pull request as draft July 26, 2022 14:38
@Boyan-MILANOV Boyan-MILANOV marked this pull request as ready for review July 27, 2022 11:31
@Boyan-MILANOV Boyan-MILANOV requested a review from ekilmer July 27, 2022 11:32
@Boyan-MILANOV
Copy link
Contributor Author

Ready for review now. I've added tests for all new simplifications. The additions are minimal despite the long commit history.

Copy link
Contributor

@ekilmer ekilmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small nits but otherwise LGTM!

Co-authored-by: Eric Kilmer <eric.d.kilmer@gmail.com>
@Boyan-MILANOV Boyan-MILANOV merged commit 5d712a0 into chess Jul 27, 2022
@Boyan-MILANOV Boyan-MILANOV deleted the chess-simplifications branch July 27, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants