Support to use boolector as the SMT solver #2410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavo-grieco
changed the title
ekilmer
reviewed
Mar 25, 2021
Contributor
ekilmer
left a comment
ekilmer
left a comment
There was a problem hiding this comment.
This is exciting! And the process for adding a new solver looks to be very easy :)
It would be nice to test basic functionality of boolector solver in CI as well.
We would need to figure out how to install it into the Ubuntu 18.04 environment and also add some tests that use boolector, which I think is as simple as following what's done here
manticore/tests/other/test_smtlibv2.py
Lines 1283 to 1290 in fd69381
Something like the following:
class ExpressionTestBoolector(ExpressionTest):
def setUp(self):
self.solver = BoolectorSolver.instance()
ekilmer
requested changes
Mar 25, 2021
Comment on lines
70
to
83
| #install boolector | ||
| mkdir -p /tmp/build | ||
| cd /tmp/build | ||
| git clone https://github.com/boolector/boolector.git | ||
| cd boolector | ||
| git checkout "f61c0dcf4a76e2f7766a6358bfb9c16ca8217224" | ||
| git log -1 --oneline > ../boolector.commit | ||
| ./contrib/setup-lingeling.sh | ||
| ./contrib/setup-btor2tools.sh | ||
| ./configure.sh | ||
| cd build | ||
| make -j4 | ||
| mkdir -p /tmp/boolector | ||
| sudo make DESTDIR=/usr install |
Contributor
There was a problem hiding this comment.
Ideally, we wouldn't have to rebuild boolector each time, but that might require messing with GH Actions caching, which can be annoying.
master branch has this Install dependencies step taking around 1:30 minutes, and now it's around 2:45 or 3 minutes.
@ehennenfent any strong feelings on this? I think maybe opening an issue to figure out caching would be fine?
ekilmer
reviewed
Mar 25, 2021
Co-authored-by: Eric Kilmer <eric.d.kilmer@gmail.com>
ekilmer
requested changes
Mar 26, 2021
Contributor
ekilmer
left a comment
ekilmer
left a comment
There was a problem hiding this comment.
Looking good!! Just a few minor things, and then I think we'll be ready for merge 🎉
Co-authored-by: Eric Kilmer <eric.d.kilmer@gmail.com>
Co-authored-by: Eric Kilmer <eric.d.kilmer@gmail.com>
Contributor
Author
|
@ekilmer can you merge this? Github says:
for some reason.. 🤔 |
ekilmer
added a commit
that referenced
this pull request
Apr 7, 2021
* master: Removed use of global solver from Native Memory (#2414) Support to use boolector as the SMT solver (#2410) Update CI and suggest to use pip3 instead of pip (#2409) Expressions use keyword-only arguments for init (#2395) Use Slots on all Expression objects (#2394) Allow double-adding exact same config option (#2397) Don't run OSX tests on PR Attempt to Fix solc Installation MacOS (#2392) Syscall specific hooks (#2389) TUI Support Infrastructure (#1620) Fix coveralls upload (#2387) docs: fix simple typo, straigth -> straight (#2381) Attempt to allow symbolic balances from the start (#1818) Fix state.cpu.PC member (#1825) Bump black and mypy (#1824)
ekilmer
added a commit
that referenced
this pull request
Apr 10, 2021
* master: (22 commits) Fix the generation of EVM tests (#2426) Disabled EVM events in testcases by default (#2417) added proper timeouts for cvc4 and boolector (#2418) Removed use of global solver from Native Memory (#2414) Support to use boolector as the SMT solver (#2410) Update CI and suggest to use pip3 instead of pip (#2409) Expressions use keyword-only arguments for init (#2395) Use Slots on all Expression objects (#2394) Allow double-adding exact same config option (#2397) Don't run OSX tests on PR Attempt to Fix solc Installation MacOS (#2392) Syscall specific hooks (#2389) TUI Support Infrastructure (#1620) Fix coveralls upload (#2387) docs: fix simple typo, straigth -> straight (#2381) Attempt to allow symbolic balances from the start (#1818) Fix state.cpu.PC member (#1825) Bump black and mypy (#1824) Manticore 0.3.5 (#1808) Fix yices timeout argument (#1817) ...
Merged
ekilmer
added a commit
that referenced
this pull request
Jul 27, 2021
* master: (35 commits) Track last_pc in StateDescriptors (#2471) Expose Result Register for Native CPU (#2470) Install pinned version of truffle to fix CI (#2467) Use fixed owner and attacker accounts in multi_tx_analysis (#2464) Manticore 0.3.6 (#2456) Fix IntrospectionAPIPlugin Name (#2459) Portfolio of parallel solvers (#2420) Replace Quick mode with Thorough mode (#2457) Fix incorrect comparison for symbolic file wildcards (#2454) Reduce the number of calls to the SMT solver in EVM (#2411) Fixes to Unicorn emulation - start/stop/resume (#1796) Add support for multiple compilation units (#2444) Basic solver stats (#2415) Fix the generation of EVM tests (#2426) Disabled EVM events in testcases by default (#2417) added proper timeouts for cvc4 and boolector (#2418) Removed use of global solver from Native Memory (#2414) Support to use boolector as the SMT solver (#2410) Update CI and suggest to use pip3 instead of pip (#2409) Expressions use keyword-only arguments for init (#2395) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch includes initial support for boolector. Only recent versions (e.g 3.2.x) are supported. Ancient versions like the one in Ubuntu 18.04 (1.5.x) are not. Closes #2403