Ek testing dev expressions

[ekilmer]

@feliam More fixes

Native tests pass, but I'm less familiar with the innerworkings of EVM stuff

This link should make it easier to review the real changes (not formatting): https://github.com/trailofbits/manticore/pull/2388/files/385afa84bba806ede871ef7caa791cc6edeb9cac..d1b1d27a692cf9671931a95c752c2887ff970d21

[ekilmer]

Some remaining tests/ethereum tests that are failing:

EthPluginsTests.test_ignore_states
EthSha3TestSymbolicate.test_essence2
EthVerifierIntegrationTest.test_propverif
EthSha3TestSymbolicate.test_essence1
EthSha3TestFake.test_essence3
EthSha3TestFake.test_essence2
EthSha3TestFake.test_essence1
EthSha3TestSymbolicate.test_essence3

[ekilmer]

Hmmmm. The native tests pass for me, but it looks like the error occurs in other platform tests too https://github.com/trailofbits/manticore/pull/2388/checks?check_run_id=1723397360#step:6:202

self = <BoolEqual at 7fdb421b3f60>

    def __bool__(self):
        raise ExpressionError(
>           "You tried to use a Bool Expression as a boolean constant. Expressions could represent a set of concrete values."
        )
E       manticore.core.smtlib.expression.ExpressionError: You tried to use a Bool Expression as a boolean constant. Expressions could represent a set of concrete values.

[ekilmer]

The native tests pass for me

After more investigation, I found that the native tests pass for me consistently while using Python 3.9.1 on Fedora 33, but using Python 3.6.12 I can get them to consistently fail in the same way as CI, but the backtrace doesn't make sense to me even while looking at it in a debug session 😞