perf: Lazy progress bar initialization in Levenshtein#109
Open
perf: Lazy progress bar initialization in Levenshtein#109
Conversation
Avoid computing fringe_ranges dict when progress bar will be disabled. Previously, the dict comprehension was computed even when DEFAULT_PRINTER.quiet was True, wasting cycles on unnecessary bounds() calls and dict allocation. Now defaults are set first, and computation only happens when the progress bar will actually be shown. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fringe_rangesdict when progress bar is disabledChanges
In
levenshtein.py, the dict comprehension forfringe_rangeswas computed even whenDEFAULT_PRINTER.quietwas True. Now defaults are set first, and computation only happens when the progress bar will actually be shown.Before:
After:
Test plan
🤖 Generated with Claude Code