Get public IP from default interface in install.sh
#1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks! |
andreimc
added a commit
to tunnelhero/algo
that referenced
this pull request
Apr 29, 2019
* upstream/master: (22 commits) Automatically create cloud firewall rules for installs onto Vultr (trailofbits#1400) Refactoring, Linting and additional tests (trailofbits#1397) Update Linux WireGuard client instructions (trailofbits#1407) Update cloud-vultr.md (trailofbits#1406) Update openssl.yml (trailofbits#1403) Update deploy-from-script-or-cloud-init-to-localhost.md Update README.md (trailofbits#1380) Update Adblock lists (trailofbits#1394) fix: get public IP from default interface (trailofbits#1396) Move `Delete the CA key` task to the appropriate role (trailofbits#1393) Update deploy-from-script-or-cloud-init-to-localhost.md Consolidate firewall documentation (trailofbits#1386) Fix 963 again (trailofbits#1379) Refactoring to support roles inclusion (trailofbits#1365) Update DNS filtering advice in FAQ (trailofbits#1389) Use VULTR_API_CONFIG variable if set (trailofbits#1374) IPv6 range to AllowedIPs only when ipv6_support (trailofbits#1388) Update ubuntu.yml (trailofbits#1383) Script to support cloud-init and local easy deploy (trailofbits#1366) Update 10-algo-lo100.network.j2 (trailofbits#1369) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
publicIpFromInterfaceininstall.shwill only get the IP from theeth0interface, which may not exist. Since there's aDEFAULT_INTERFACEdefined directly above it and that isn't used anywhere else, I guess that's supposed to be used.Description
Get the IP from the default interface instead of always
eth0.Motivation and Context
eth0may not be the default interface.How Has This Been Tested?
I ran the altered script in an environment without an
eth0and that got set up. I didn't see a way to run tests inCONTRIBUTING.md, so I guess it's supposed to go through CI.Types of changes
Checklist: