Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collections #36

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Collections #36

wants to merge 3 commits into from

Conversation

timoschilling
Copy link
Contributor

add Roar::Representer::JSON::Collection and Roar::Representer::XML::Collection

close #35

@timoschilling
Copy link
Contributor Author

what's up here?

@KevinTriplett
Copy link

Are you referring to adding the ability to call #to_json and #to_xml on a collection? -- whoops, sorry, I should have looked at your commits. : S

@apotonick
Copy link
Member

Is this just for the naming, i.e. aliasing Representer::JSON::Collection to Roar::JSON::Collection?

@timoschilling
Copy link
Contributor Author

It is not only an alias, it is also to use Feature::Http on Collections

@apotonick
Copy link
Member

Can you describe what how you relate those Collection modules with the Http Feature, I think I am missing something here?

@skroll
Copy link

skroll commented Apr 4, 2013

I think the purpose of this is to add support for lonely collections. I was looking for a solution to parse a naked array of JSON objects, and this does the trick.

@apotonick
Copy link
Member

@skroll you just used the Lonely Collections feature from representable then, right? @timoschilling it looks as if this is just an aliasing issue for Roar users, is that right or not? Please provide some infos on how you intend to use classes introduced in this PR.

@skroll
Copy link

skroll commented Apr 11, 2013

Yes, it is an alias for lonely collections support from Representable. I'm not 100% sure if this is something that should be included in Roar but it seems that Roar puts a lot of effort in abstracting away Representable from the end-user of the library, so this may not be a bad idea.

@myabc
Copy link
Contributor

myabc commented Jul 25, 2013

For the sake of consistency, this makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Roar::Representer::***::Collection
5 participants