-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collections #36
base: master
Are you sure you want to change the base?
Collections #36
Conversation
what's up here? |
Are you referring to adding the ability to call |
Is this just for the naming, i.e. aliasing |
It is not only an alias, it is also to use Feature::Http on Collections |
Can you describe what how you relate those Collection modules with the Http Feature, I think I am missing something here? |
I think the purpose of this is to add support for lonely collections. I was looking for a solution to parse a naked array of JSON objects, and this does the trick. |
@skroll you just used the Lonely Collections feature from representable then, right? @timoschilling it looks as if this is just an aliasing issue for Roar users, is that right or not? Please provide some infos on how you intend to use classes introduced in this PR. |
Yes, it is an alias for lonely collections support from Representable. I'm not 100% sure if this is something that should be included in Roar but it seems that Roar puts a lot of effort in abstracting away Representable from the end-user of the library, so this may not be a bad idea. |
For the sake of consistency, this makes sense. |
add Roar::Representer::JSON::Collection and Roar::Representer::XML::Collection
close #35