Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🚫DO NOT MERGE 🚫] Cimb 1 FA oauth flow #348

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

[🚫DO NOT MERGE 🚫] Cimb 1 FA oauth flow #348

wants to merge 11 commits into from

Commits on Oct 17, 2018

  1. Cimb - implements 1 FA for trading

    @guillaumedebavelaere
    guillaumedebavelaere authored and guillaumedebavelaere committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    953a600 View commit details
    Browse the repository at this point in the history

  2. Cimb - Yahoo screen - Implements trading 1FA

    @guillaumedebavelaere
    guillaumedebavelaere authored and guillaumedebavelaere committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    d1af8ea View commit details
    Browse the repository at this point in the history

  3. Cimb - implements 1 FA when canceling an order

    @guillaumedebavelaere
    guillaumedebavelaere authored and guillaumedebavelaere committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    b247172 View commit details
    Browse the repository at this point in the history

  4. Cimb - Yahoo - implements 1 FA when canceling an order

    @guillaumedebavelaere
    guillaumedebavelaere authored and guillaumedebavelaere committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    9298596 View commit details
    Browse the repository at this point in the history

  5. Remove 1FA implementation for Yahoo

    @guillaumedebavelaere
    guillaumedebavelaere authored and guillaumedebavelaere committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    d02af49 View commit details
    Browse the repository at this point in the history

  6. Refactor to avoid duplicated code

    @guillaumedebavelaere
    guillaumedebavelaere authored and guillaumedebavelaere committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    db1a85c View commit details
    Browse the repository at this point in the history

  7. Fix naming + error messaging

    @guillaumedebavelaere
    guillaumedebavelaere authored and guillaumedebavelaere committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    76d9921 View commit details
    Browse the repository at this point in the history

  8. Orders screen -> return order expiration label based on the order cap… 

    …abilities
    @guillaumedebavelaere
    guillaumedebavelaere authored and guillaumedebavelaere committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    94c6cb3 View commit details
    Browse the repository at this point in the history

  9. Order screen - Fix refreshing issue when coming back from oauth flow

    @guillaumedebavelaere
    guillaumedebavelaere authored and guillaumedebavelaere committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    3154513 View commit details
    Browse the repository at this point in the history

  10. Fix rebase issues

    @guillaumedebavelaere
    guillaumedebavelaere authored and guillaumedebavelaere committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    28fe7e7 View commit details
    Browse the repository at this point in the history

  11. hide market data label if CIMB

    @guillaumedebavelaere
    guillaumedebavelaere committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    55de80a View commit details
    Browse the repository at this point in the history