Skip to content

Make Testing classes easier #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 3, 2025
Merged

Make Testing classes easier #24

merged 6 commits into from
Jul 3, 2025

Conversation

chadicus
Copy link
Contributor

@chadicus chadicus commented Jul 2, 2025 •
edited
Loading

What does this PR do?

  • Removes the hard coded netacuity url and set it as a class property. This will allow easier testing.
  • Adds an exclude rule for PSR12 constant visibility in php versions >= 7.1
  • Adds NetacuityException

Checklist

  • [ ] Pull request contains a clear definition of changes
  • [ ] Tests (either unit, integration, or acceptance) written and passing
  • [ ] Relevant documentation produced and/or updated

@chadicus chadicus changed the title NEBULOUS-1027: Allow netacuity url to be injected NEBULOUS-1037: Allow netacuity url to be injected Jul 2, 2025
@chadicus chadicus marked this pull request as ready for review July 2, 2025 14:00
@chadicus chadicus requested a review from a team as a code owner July 2, 2025 14:00
@chadicus chadicus changed the title NEBULOUS-1037: Allow netacuity url to be injected NEBULOUS-1037: Make Testing classes easier Jul 2, 2025
jncarver
jncarver previously approved these changes Jul 2, 2025
View reviewed changes
@chadicus @jncarver
Update src/Databases/AbstractNetAcuityDatabase.php
a97cf64 
Co-authored-by: James Carver <git@jamesncarver.com>
@chadicus chadicus changed the title NEBULOUS-1037: Make Testing classes easier Make Testing classes easier Jul 3, 2025
@chadicus chadicus merged commit 293c855 into traderinteractive:master Jul 3, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jncarver jncarver jncarver approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chadicus @jncarver