MNT Replace sass-lint with stylelint #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
GuySartorelli
force-pushed
the
pulls/7.1/scss-lint
branch
from
35423f4
to
bfeba2c
Compare
sass-lint went EOL ages ago
GuySartorelli
force-pushed
the
pulls/7.1/scss-lint
branch
from
bfeba2c
to
23fe99a
Compare
emteknetnz
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT
Do not merge until silverstripe/eslint-config#26 has been merged and published in NPM, and this PR has been updated to pull in the new version.
Description
sass lint went EOL ages ago. stylelint is the recommended replacement.
This should have been done as part of silverstripe/webpack-config#69 but it got missed.
Issues