Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Set extension hook implementation visibility to protected #852

Merged
merged 2 commits into from
May 21, 2024
Merged

API Set extension hook implementation visibility to protected #852

merged 2 commits into from
May 21, 2024

Conversation

emteknetnz
Copy link
Contributor

Issue silverstripe/silverstripe-framework#10514

Includes two commits:

  1. Set a public extension method to protected that was missed on the first PR
  2. Updating documentation examples

@emteknetnz emteknetnz mentioned this pull request May 21, 2024
Closed
3 tasks
@tractorcow tractorcow merged commit 80a09b0 into tractorcow-farm:8 May 21, 2024
10 checks passed
@emteknetnz emteknetnz deleted the pulls/8/protect-hooks-2 branch May 21, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tractorcow tractorcow tractorcow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @tractorcow