MNT Run module-standardiser #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/7/module-standardiser-1715811882
branch
from
43c507c
to
db1e00b
Compare
4 tasks
emteknetnz
force-pushed
the
pulls/7/module-standardiser-1715811882
branch
from
db1e00b
to
ffa1bb0
Compare
GuySartorelli
approved these changes
May 16, 2024
There was a problem hiding this comment.
LGTM, cron change is expected as per silverstripe/.github#242, and permissions changes provide some additional protection against unexpected attack vectors from CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request was created automatically by module-standardiser