Feature SCIM fixes current branch #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Wrong attributes should not be allowed - Required attributes not enforced
ErebusBat
force-pushed
the
feature-scim-fixes-current-branch
branch
from
2ba5c0f to
0061888
Compare
scottyhagan
approved these changes
Nov 9, 2021
pluus
approved these changes
Nov 10, 2021
added 2 commits
November 16, 2021 21:31
- Fix missing fields. - It is a pain to duplicate the schema fields in the spec; however: - It makes sure that we don't miss any
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Some clients want a request with invalid parameters to be treated as invalid, rather than the invalid parameters just being ignored.
What?
Caveats
Because requests with invalid parameters will now be rejected rather than ignore this could cause an uptick in error rate...
HOWEVER this shouldn't affect anything in practice as the invalid parameters should have just been silently ignored in the past
Required by https://github.com/tractionguest/guest-server/pull/2673