handle SCIM schema extensions on patch_update #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pluus
reviewed
Aug 20, 2021
| # Must use .to_s.downcase to handle strings "True" and "False" | ||
| # Which is sent by Azure AD | ||
| # Other possible inputs (true, "true", false, "false", 0, 1, nil) | ||
| ActiveModel::Type::Boolean.new.cast(active_param.to_s.downcase) |
There was a problem hiding this comment.
Hmmm 💭 two thoughts on this.
- I can't find tests around this... where can I find them?
- Looks like we're casting any value now instead of raising
ScimRails::ExceptionHandler::InvalidActiveParamon some values that shouldn't be used.
For example, the following inputs are now valid.
[5] pry(main)> ActiveModel::Type::Boolean.new.cast({}.to_s.downcase)
=> true
[7] pry(main)> ActiveModel::Type::Boolean.new.cast([].to_s.downcase)
=> true
Is it an intentional change?
Author
There was a problem hiding this comment.
I see your your point but as i put in the comments on the line above so far we know the possible inputs from various identity providers and what we know are possible inputs are (true, "true", "True", false, "false", "False", 0, 1, nil). So based on this I still think its an adequate solution
pluus
approved these changes
Aug 20, 2021
ShabiniRajadas
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
When the
ScimUsersController#patch_updateendpoint was hit and had anoperationwith apathvalue that used SCIM's schema extensionsurn:ietf:params:scim:schemas:extension:enterprise:2.0:User, it would not parse this parameter properly resulting in the underlying attribute never getting updated.What?
Added a handler for scenarios where we receive a paramater that is part of SCIM's schema extensions. It isn't pretty but it gets the job done.
Also refactored a case statement that didn't handle when the operation sent the
activeattribute as"True"or"False". Simplified it to cast it as a boolean to handle that scenario and get rid of the case statement