WORKAROUND: ignore default scopes on user model #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pluus
approved these changes
Apr 7, 2021
myang0
approved these changes
Apr 7, 2021
|
Does it have a JIRA ticket? 🤔 |
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA
https://tractionguest.atlassian.net/browse/SST-17083
Description
I am making a change to our package to handle the use of
default_scopein our projects SCIM "User" model. We are raising exceptions when trying to create users where thedefault_scopeattribute is set tofalse. This PR unscopes the lookup to work around it.We should be reverting this back once we remove the
default_scopefrom our model, because if for whatever reason we were to try and publish this back to the original repo or some other public gem it could cause problems for people where they want thedefault_scopeto be respected.Just another lesson in why we should avoid using
default_scopes