Idaptive integration #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenallen05
suggested changes
Dec 16, 2020
stevenallen05
left a comment
stevenallen05
left a comment
There was a problem hiding this comment.
According to the test metrics, there's a lot of code branches that aren't tested. The lines are hit, but due to them being single-line conditionals, there's a lot of code branches that are never tested:
ShabiniRajadas
approved these changes
Dec 16, 2020
stevenallen05
approved these changes
Dec 17, 2020
ErebusBat
pushed a commit
that referenced
this pull request
Oct 28, 2021
…2.4.2 Bump actionview from 5.2.4.1 to 5.2.4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
There are several extra endpoints needed to support Idaptive as an idp. They require four extra endpoints. One for service providers configs, two for resource types and one for schemas. All are listed as part of the SCIM spec (https://tools.ietf.org/html/rfc7644)
What?
Add the four required endpoints to support Idaptive as an idp.