Feature/configurable canonical ref #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenallen05
approved these changes
Jun 16, 2020
bj-mcduck
reviewed
Jul 2, 2020
| update_group_status(group) unless put_active_param.nil? | ||
|
|
||
| ScimRails.config.after_scim_response.call(group, "CREATED") unless ScimRails.config.after_scim_response.nil? | ||
| final_callback_hook(group, "CREATED") |
There was a problem hiding this comment.
where are these methods coming from?
is this call still conditional?
Author
There was a problem hiding this comment.
It's from application_controller.rb, I made it so it would check in the methods I made there instead
bj-mcduck
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Prior to this PR, it was only possible to find SCIM Users/Groups by their
id. This PR adds more configuration options in thecanonical_referencevariable which allows for Users/Groups to be found by theiruuidas well now, which would greatly improve security.What?
canonical_referencevariable to the configuration which must be set to either:idor:uuidcanonical_referenceto:uuid, change tests accordingly as a resultuuidto both User and Group models within the dummy app for testing purposes