Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Storage): S3 bucket instead of EC2 storage for images and thumbnails #17

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

mezzLMC
Copy link
Contributor

@mezzLMC mezzLMC commented Nov 30, 2023

strapi-provider-upload-aws-s3 lets us use an S3 bucket as storage for our various images, instead of using the storage system of the machine hosting the server.

the problem was that it required a user's full credentials (access key + secret Key) to work.

A patch was therefore applied so that it would use these values when they were supplied, or let aws-sdk use system authentication when no credentials were supplied.

@nathanagez nathanagez marked this pull request as ready for review December 1, 2023 14:12
Copy link
Member

@nathanagez nathanagez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanagez nathanagez merged commit 810581e into main Dec 1, 2023
@nathanagez nathanagez deleted the feat/strapi/s3-image-storage branch December 1, 2023 14:17
mezzLMC added a commit that referenced this pull request Dec 11, 2023
…ails (#17)

* feat(s3): default plugin config + no credentials patch
---------

Co-authored-by: Nathan Agez <nathan.agez@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants