Skip to content

Conversation

@ShabiShett07
Copy link
Contributor

Progresses #17

Adds Anthropic Model

@ShabiShett07 ShabiShett07 marked this pull request as ready for review August 3, 2025 10:16
@ShabiShett07 ShabiShett07 requested a review from a team as a code owner August 3, 2025 10:16
Copy link
Collaborator

@zechengz zechengz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM, left some comments. Thanks! :)

tree: SpanNode,
chat_history: list[dict] | None = None,
openai_token: str | None = None,
anthropic_token: str | None = None,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change the openai_token to llm_token and use it for both openai or anthropic. Let's create one type such as LLMProvider which has enum openai and anthropic and in rest/routers/explore.py when post_chat (ChatRequest) let's add one param llm_provider (for now default as openai).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any difference with the openai one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants