-
Notifications
You must be signed in to change notification settings - Fork 48
Add Anthropic Model #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
zechengz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general LGTM, left some comments. Thanks! :)
| tree: SpanNode, | ||
| chat_history: list[dict] | None = None, | ||
| openai_token: str | None = None, | ||
| anthropic_token: str | None = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's change the openai_token to llm_token and use it for both openai or anthropic. Let's create one type such as LLMProvider which has enum openai and anthropic and in rest/routers/explore.py when post_chat (ChatRequest) let's add one param llm_provider (for now default as openai).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any difference with the openai one?
Progresses #17
Adds Anthropic Model