fix(openai): remove redundant try/finally in ResponseStream close and aclose

[dvirski]

Fixes #3969 — Python 3.14 SyntaxWarning caused by return statement inside finally block in ResponseStream close/aclose

Summary by CodeRabbit

• Bug Fixes
  • Improved cleanup when closing streamed responses in the OpenAI integration, reducing the chance of lingering resources and improving stability for consumers of streaming functionality.
  • Both synchronous and asynchronous stream closures are now handled more reliably, decreasing resource leaks and connection issues for streaming use cases.

[CLAassistant]

All committers have signed the CLA.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9343c7d3-5267-4cdd-a159-806c0a8b3a7a

📥 Commits

Reviewing files that changed from the base of the PR and between 40faa87 and 4d6f7e0.

📒 Files selected for processing (1)

• packages/opentelemetry-instrumentation-openai/opentelemetry/instrumentation/openai/v1/responses_wrappers.py

🚧 Files skipped from review as they are similar to previous changes (1)

• packages/opentelemetry-instrumentation-openai/opentelemetry/instrumentation/openai/v1/responses_wrappers.py

---

📝 Walkthrough

Walkthrough

ResponseStream.close() and ResponseStream.aclose() now call _ensure_cleanup() directly, then conditionally delegate to the wrapped stream's close/aclose when present, removing the previous try/finally around the cleanup call.

Changes

ResponseStream cleanup delegation

Layer / File(s)	Summary
ResponseStream close/aclose update packages/opentelemetry-instrumentation-openai/opentelemetry/instrumentation/openai/v1/responses_wrappers.py	ResponseStream.close() and ResponseStream.aclose() call _ensure_cleanup() and then delegate to the wrapped object's close()/aclose() if available; the prior try/finally was removed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

• galzilber
• nina-kollman
• max-deygin-traceloop
• netanel-tl
• doronkopit5

Poem

🐰 I nudged the stream to say goodnight,
Cleanup first, then dim the light,
No tangled finally to make me frown,
I hop away as logs go down,
Close and aclose — the burrow's right.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: removing redundant try/finally blocks in ResponseStream close and aclose methods.
Linked Issues check	✅ Passed	The code changes directly address issue #3969 by removing return statements from finally blocks to eliminate the Python 3.14 SyntaxWarning.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to fixing the SyntaxWarning issue in ResponseStream close and aclose methods; no unrelated modifications present.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix(openai)-remove-redundant-try/finally-in-ResponseStream-close-and-aclose-

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[doronkopit5]

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}