Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 71 additions & 13 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@ on:
branches:
- "main"

env:
POETRY_CACHE_DIR: /tmp/pypoetry-cache
POETRY_VENV_IN_PROJECT: false
POETRY_INSTALLER_MODERN_INSTALLATION: false
PIP_NO_CACHE_DIR: 1

jobs:
lint-pr:
name: Lint PR
Expand All @@ -28,11 +34,17 @@ jobs:
steps:
- name: Free up disk space
run: |
# Remove unnecessary software and cached packages
sudo apt-get remove -y '^dotnet-.*' '^llvm-.*' 'php.*' '^mongodb-.*' '^mysql-.*' azure-cli google-cloud-cli google-chrome-stable firefox powershell mono-devel libgl1-mesa-dri || true
sudo apt-get autoremove -y
sudo apt-get clean
# Remove Docker images
docker rmi $(docker images -aq) || true
# Remove Docker images and containers
docker system prune -af || true
# Remove additional system files
sudo rm -rf /usr/share/dotnet /usr/local/lib/android /opt/ghc /opt/hostedtoolcache/CodeQL || true
sudo rm -rf /imagegeneration || true
# Clear APT cache completely
sudo rm -rf /var/lib/apt/lists/* /var/cache/apt/archives/* || true
# Show available space
df -h
- uses: actions/checkout@v4
Expand All @@ -46,13 +58,20 @@ jobs:
python-version: 3.11
- name: Install Poetry
uses: snok/install-poetry@v1
with:
version: latest
virtualenvs-create: true
virtualenvs-in-project: false
virtualenvs-path: ~/.cache/pypoetry/virtualenvs

- uses: actions/setup-node@v4
with:
node-version: 18

- uses: nrwl/nx-set-shas@v4
- run: npm ci
- run: npm ci --cache ~/.npm --prefer-offline
- name: Clean npm cache
run: npm cache clean --force || true
- run: npx nx affected -t install --with dev
- run: npx nx affected -t lint --parallel=3

Expand All @@ -66,11 +85,17 @@ jobs:
steps:
- name: Free up disk space
run: |
# Remove unnecessary software and cached packages
sudo apt-get remove -y '^dotnet-.*' '^llvm-.*' 'php.*' '^mongodb-.*' '^mysql-.*' azure-cli google-cloud-cli google-chrome-stable firefox powershell mono-devel libgl1-mesa-dri || true
sudo apt-get autoremove -y
sudo apt-get clean
# Remove Docker images
docker rmi $(docker images -aq) || true
# Remove Docker images and containers
docker system prune -af || true
# Remove additional system files
sudo rm -rf /usr/share/dotnet /usr/local/lib/android /opt/ghc /opt/hostedtoolcache/CodeQL || true
sudo rm -rf /imagegeneration || true
# Clear APT cache completely
sudo rm -rf /var/lib/apt/lists/* /var/cache/apt/archives/* || true
# Show available space
df -h
- uses: actions/checkout@v4
Expand All @@ -83,20 +108,33 @@ jobs:
python-version: ${{ matrix.python-version }}
- name: Install Poetry
uses: snok/install-poetry@v1
with:
version: latest
virtualenvs-create: true
virtualenvs-in-project: false
virtualenvs-path: ~/.cache/pypoetry/virtualenvs

- uses: actions/setup-node@v4
with:
node-version: 18

- uses: nrwl/nx-set-shas@v4

- run: npm ci
- run: npm ci --cache ~/.npm --prefer-offline
- name: Clean npm cache
run: npm cache clean --force || true

- name: Install
run: npx nx affected -t install --with dev --parallel=3
run: npx nx affected -t install --with dev --parallel=2


- name: Build
run: npx nx affected -t build-release --parallel=3
run: npx nx affected -t build-release --parallel=2

- name: Clean build artifacts to save space
run: |
find packages -name "dist" -type d -exec rm -rf {} + || true
find packages -name "*.egg-info" -type d -exec rm -rf {} + || true

Comment on lines 131 to 138
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

YAML lint: Remove trailing whitespace-only line after Build step

Yamllint flags trailing spaces at Line 143. Drop the whitespace-only line.

Apply:

       - name: Build
-        run: npx nx affected -t build-release --parallel=2
-        
+        run: npx nx affected -t build-release --parallel=2

Optional extra space savings after build: remove Poetry venvs if not needed afterwards in this job.

       - name: Clean build artifacts to save space
         run: |
           find packages -name "dist" -type d -exec rm -rf {} + || true
           find packages -name "*.egg-info" -type d -exec rm -rf {} + || true
+          rm -rf ~/.cache/pypoetry/virtualenvs || true
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- name: Build
run: npx nx affected -t build-release --parallel=3
run: npx nx affected -t build-release --parallel=2
- name: Clean build artifacts to save space
run: |
find packages -name "dist" -type d -exec rm -rf {} + || true
find packages -name "*.egg-info" -type d -exec rm -rf {} + || true
- name: Build
run: npx nx affected -t build-release --parallel=2
- name: Clean build artifacts to save space
run: |
find packages -name "dist" -type d -exec rm -rf {} + || true
find packages -name "*.egg-info" -type d -exec rm -rf {} + || true
rm -rf ~/.cache/pypoetry/virtualenvs || true
🧰 Tools
🪛 YAMLlint (1.37.1)

[error] 143-143: trailing spaces

(trailing-spaces)

🤖 Prompt for AI Agents
In .github/workflows/ci.yml around lines 141 to 148, remove the trailing
whitespace-only blank line immediately after the "Build" step (line 143) so
yamllint no longer flags trailing spaces; ensure no trailing spaces remain on
that line and save the file. Optionally, to save extra space after the build,
add a subsequent cleanup command to remove Poetry virtualenvs (for example by
deleting Poetry's virtualenv cache or removing created venvs) in the same
cleanup block.

test-packages:
name: Test Packages
Expand All @@ -111,11 +149,17 @@ jobs:
steps:
- name: Free up disk space
run: |
# Remove unnecessary software and cached packages
sudo apt-get remove -y '^dotnet-.*' '^llvm-.*' 'php.*' '^mongodb-.*' '^mysql-.*' azure-cli google-cloud-cli google-chrome-stable firefox powershell mono-devel libgl1-mesa-dri || true
sudo apt-get autoremove -y
sudo apt-get clean
# Remove Docker images
docker rmi $(docker images -aq) || true
# Remove Docker images and containers
docker system prune -af || true
# Remove additional system files
sudo rm -rf /usr/share/dotnet /usr/local/lib/android /opt/ghc /opt/hostedtoolcache/CodeQL || true
sudo rm -rf /imagegeneration || true
# Clear APT cache completely
sudo rm -rf /var/lib/apt/lists/* /var/cache/apt/archives/* || true
# Show available space
df -h
- uses: actions/checkout@v4
Expand All @@ -130,19 +174,33 @@ jobs:

- name: Install Poetry
uses: snok/install-poetry@v1
with:
version: latest
virtualenvs-create: true
virtualenvs-in-project: false
virtualenvs-path: ~/.cache/pypoetry/virtualenvs

- uses: actions/setup-node@v4
with:
node-version: 18

- uses: nrwl/nx-set-shas@v4

- run: npm ci
- run: npm ci --cache ~/.npm --prefer-offline
- name: Clean npm cache
run: npm cache clean --force || true

- name: Install
run: npx nx affected -t install --exclude='sample-app' --with dev --parallel=3
run: npx nx affected -t install --exclude='sample-app' --with dev --parallel=2


- name: Test
env:
HAYSTACK_TELEMETRY_ENABLED: False
run: npx nx affected -t test --exclude='sample-app' --exclude='opentelemetry-instrumentation-haystack' --parallel=3
run: npx nx affected -t test --exclude='sample-app' --exclude='opentelemetry-instrumentation-haystack' --parallel=2

Comment on lines 198 to +201
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

YAML lint: remove trailing whitespace-only line after Test step

Static analysis flags trailing spaces at Line 201. Remove the whitespace-only line.

       - name: Test
         env:
           HAYSTACK_TELEMETRY_ENABLED: False
         run: npx nx affected -t test --exclude='sample-app' --exclude='opentelemetry-instrumentation-haystack' --parallel=2
-        
+
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
env:
HAYSTACK_TELEMETRY_ENABLED: False
run: npx nx affected -t test --exclude='sample-app' --exclude='opentelemetry-instrumentation-haystack' --parallel=3
run: npx nx affected -t test --exclude='sample-app' --exclude='opentelemetry-instrumentation-haystack' --parallel=2
- name: Test
env:
HAYSTACK_TELEMETRY_ENABLED: False
run: npx nx affected -t test --exclude='sample-app' --exclude='opentelemetry-instrumentation-haystack' --parallel=2
🧰 Tools
🪛 YAMLlint (1.37.1)

[error] 201-201: trailing spaces

(trailing-spaces)

🤖 Prompt for AI Agents
In .github/workflows/ci.yml around lines 198 to 201 there is a trailing
whitespace-only blank line after the Test step which triggers YAML lint; remove
that empty/whitespace-only line so the run block ends immediately after the
command (ensure no extra spaces or blank line remains) to satisfy the linter and
keep the YAML valid.

- name: Clean test artifacts to save space
run: |
find packages -name ".pytest_cache" -type d -exec rm -rf {} + || true
find packages -name "__pycache__" -type d -exec rm -rf {} + || true
find packages -name "*.pyc" -delete || true
2 changes: 1 addition & 1 deletion packages/traceloop-sdk/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"options": {
"silent": false,
"args": "",
"cacheDir": ".cache/pypoetry",
"cacheDir": "/tmp/pypoetry-cache",
"verbose": false,
"debug": false
}
Expand Down