-
Notifications
You must be signed in to change notification settings - Fork 808
Revert "chore(ci): reduce disk space usage" #3293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit b0dfd92.
Caution Review failedThe pull request is closed. WalkthroughThis PR updates GitHub Actions workflows by removing Poetry/pip/Nx caching, Poetry CI configuration, and artifact cleanup steps. It also modifies the release workflow to stop building instrumentations/SDK and instead package existing instrumentation artifacts by copying from built dist directories before publishing. Changes
Sequence Diagram(s)sequenceDiagram
actor Dev as Maintainer
participant GH as GitHub Actions
participant Rel as Release Workflow
participant Inst as Instrumentations Artifacts
participant PyPI as PyPI
Dev->>GH: Push tag / trigger release
GH->>Rel: Start release jobs
Rel->>Rel: Skip Poetry/Nx caching/config
Rel->>Inst: Copy dist artifacts to instrumentations-dist
Rel->>PyPI: Publish using assembled artifacts
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to faf757b in 53 seconds. Click for details.
- Reviewed
229
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
2
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/ci.yml:38
- Draft comment:
Revert removes Poetry and Nx caching and cleanup steps. This reversion restores the previous CI behavior and may affect build performance and disk usage. Ensure the removal is intentional. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
2. .github/workflows/release.yml:63
- Draft comment:
Revert removes caching and cleanup steps in the release workflow. Confirm that restoring the previous behavior (pre-#3288) is deliberate and acceptable regarding CI performance and disk usage. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
Workflow ID: wflow_kKCxQuMh1JsmnIzX
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Reverts #3288
Important
Reverts disk space optimization changes in CI and release workflows, removing caching and cleanup steps.
.github/workflows/ci.yml
and.github/workflows/release.yml
..pyc
files and__pycache__
directories).This description was created by
for faf757b. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit