Skip to content

Conversation

galkleinman
Copy link
Contributor

@galkleinman galkleinman commented Aug 17, 2025

Reverts #3288


Important

Reverts disk space optimization changes in CI and release workflows, removing caching and cleanup steps.

  • Revert Changes:
    • Reverts disk space optimization changes in .github/workflows/ci.yml and .github/workflows/release.yml.
    • Removes caching of Poetry dependencies and Nx cache.
    • Removes cleanup of build artifacts (e.g., .pyc files and __pycache__ directories).

This description was created by Ellipsis for faf757b. You can customize this summary. It will automatically update as commits are pushed.

Summary by CodeRabbit

  • Chores
    • Streamlined CI by removing several caching and cleanup steps to reduce pipeline complexity.
    • Simplified release workflow by packaging prebuilt instrumentation artifacts instead of building them during release.
    • Removed redundant SDK build step from the release process.
    • Maintained existing build/test execution for unaffected parts of the pipeline.
    • No changes to public APIs or runtime behavior.

Copy link

coderabbitai bot commented Aug 17, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This PR updates GitHub Actions workflows by removing Poetry/pip/Nx caching, Poetry CI configuration, and artifact cleanup steps. It also modifies the release workflow to stop building instrumentations/SDK and instead package existing instrumentation artifacts by copying from built dist directories before publishing.

Changes

Cohort / File(s) Summary
CI workflow cleanup
.github/workflows/ci.yml
Removed Poetry CI config, Poetry/pip caches, Nx cache, and cleanup steps across lint/build/test jobs; retained installation and build/test invocations.
Release workflow adjustments
.github/workflows/release.yml
Removed Poetry/Nx CI config and caches, cleanup, and full build steps for instrumentations and SDK. Added steps to assemble instrumentations-dist by copying from packages/opentelemetry-instrumentation-/dist/; publishing steps remain.

Sequence Diagram(s)

sequenceDiagram
  actor Dev as Maintainer
  participant GH as GitHub Actions
  participant Rel as Release Workflow
  participant Inst as Instrumentations Artifacts
  participant PyPI as PyPI

  Dev->>GH: Push tag / trigger release
  GH->>Rel: Start release jobs
  Rel->>Rel: Skip Poetry/Nx caching/config
  Rel->>Inst: Copy dist artifacts to instrumentations-dist
  Rel->>PyPI: Publish using assembled artifacts
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • nirga

Poem

I nibbled the caches, chomp chomp, gone—
Swept stray pyc like dew at dawn.
No builds today, just copy and hop,
into dist baskets—plop, plop, plop.
Release bells ring, my paws applaud—
Ship the carrots! Fast and awed. 🥕🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 227573b and faf757b.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml (0 hunks)
  • .github/workflows/release.yml (0 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revert-3288-gk/ci-disk-space

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@galkleinman galkleinman merged commit afe205d into main Aug 17, 2025
8 of 9 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to faf757b in 53 seconds. Click for details.
  • Reviewed 229 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/ci.yml:38
  • Draft comment:
    Revert removes Poetry and Nx caching and cleanup steps. This reversion restores the previous CI behavior and may affect build performance and disk usage. Ensure the removal is intentional.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. .github/workflows/release.yml:63
  • Draft comment:
    Revert removes caching and cleanup steps in the release workflow. Confirm that restoring the previous behavior (pre-#3288) is deliberate and acceptable regarding CI performance and disk usage.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_kKCxQuMh1JsmnIzX

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant