-
Notifications
You must be signed in to change notification settings - Fork 718
Test to recreate metal bug #3609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Implemented broadcasting for add, sub, mul, and div operations between tensors of different ranks in BinaryNode. Added new ONNX test models and Rust tests to verify correct broadcasting behavior for various tensor rank combinations.
Enhances the YOLO11x model check by loading test input/output from a PyTorch file, running inference, and comparing the model output to reference data with detailed statistics. Updates dependencies and features in Cargo.toml, improves build script to track test data, and refines the Python script for model and test data preparation.
Updated slice range generation to treat i64::MAX as an open-ended range (..), and added checks to prevent slice end indices from exceeding i32::MAX. Also replaced alloc::vec::Vec with Vec for clarity and consistency.
Introduce a new crate 'burn-metal-bug' with two binaries: 'single-layer' and 'deep-network'. These binaries provide comprehensive tests comparing Metal, Tch, and Ndarray backends for various layers and deep network architectures, focusing on error accumulation and identifying backend-specific numerical issues, especially in Conv2d.
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (64.02%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3609 +/- ##
=======================================
Coverage 64.02% 64.02%
=======================================
Files 1084 1084
Lines 126894 126894
=======================================
Hits 81238 81238
Misses 45656 45656 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@louisfd @wingertge This bug still persist. |
@ArthurBrussee Could it be the same subgroup bug? |
No, the subgroup stuff just crashes as the MSL kernel doesn't compile |
|
|
This PR contains tests to recreate #3600
NOTE: this PR based off #3599 PR that's why you see Yolo11x related tests.
This deep layers test can highlight the discrepancy in outputs between tch and metal especially for ResNet type of models.
DEEP
See the output down below.
SHALLOW
See the output down below.