Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize accumulator to bias for implicit GEMM to save an expensive float_add #2383

Merged
merged 40 commits into from
Oct 20, 2024

Conversation

wingertge
Copy link
Contributor

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Changes

Loads the bias into the initial accumulator if present, to avoid an unnecessary extra binop.

Testing

All existing tests pass and no behaviour was changed

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 86 lines in your changes missing coverage. Please review.

Project coverage is 85.18%. Comparing base (eaf50e6) to head (87ad9fb).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...s/burn-jit/src/kernel/conv/conv2d/implicit_gemm.rs 0.00% 86 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2383      +/-   ##
==========================================
- Coverage   85.23%   85.18%   -0.06%     
==========================================
  Files         785      785              
  Lines      103756   103823      +67     
==========================================
  Hits        88437    88437              
- Misses      15319    15386      +67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nathanielsimard nathanielsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanielsimard nathanielsimard merged commit cb819ad into tracel-ai:main Oct 20, 2024
11 checks passed
@wingertge wingertge deleted the opt/implicit-gemm-bias branch October 20, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants