-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize accumulator to bias for implicit GEMM to save an expensive float_add
#2383
Initialize accumulator to bias for implicit GEMM to save an expensive float_add
#2383
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2383 +/- ##
==========================================
- Coverage 85.23% 85.18% -0.06%
==========================================
Files 785 785
Lines 103756 103823 +67
==========================================
Hits 88437 88437
- Misses 15319 15386 +67 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request Template
Checklist
run-checks all
script has been executed.Changes
Loads the bias into the initial accumulator if present, to avoid an unnecessary extra binop.
Testing
All existing tests pass and no behaviour was changed