ultisnips deprecated function

[blaenk]

I keep getting nagged by UltiSnips whenever I open a file relevant to vim-rails with the message:

UltiSnipsAddFiletypes is deprecated, which snippets are used is determined by a function returning snippet files now

I think this is the offending line: https://github.com/tpope/vim-rails/blob/master/autoload/rails.vim#L4488

[tpope]

Removed. Someone LMK if there's something I should be doing instead.

[SirVer]

@blaenk Where did you track your UltiSnips from? There was a fork in the wild that promoted itself, but this one is abandoned and has no additional features anymore compared to my official version. It is unfortunate that this has led to a lost feature for all users of ultisnips.

Tim, could you revert this change again and just ping me whenever an issue with ultisnips shows up. I'll take care of it.

[blaenk]

@SirVer Then I'm not sure if perhaps I used another one when I filed this issue, because apparently I'm using yours.

[SirVer]

I found it here: https://github.com/MarcWeber/ultisnips/blob/master/plugin/UltiSnips.vim#L184 . I got bug reports against this fork before, but it was never supported by me in any way. I think this settles this issue. @tpope, would you please revert fcd1178 again? Sorry for all this noise.

[tpope]

Already reverted, you're not asking me to revert the reversion are you?

Pretty big dick move to create an incompatible fork and not rename.

[SirVer]

Pretty big dick move to create an incompatible fork and not rename.

You said that, not me. :). Thanks for the quick help.