Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added GSP to list of supported filetypes #20

Closed
wants to merge 2 commits into from
Closed

added GSP to list of supported filetypes #20

wants to merge 2 commits into from

Conversation

eliasdorneles
Copy link

refers to issue #19

@tpope
Copy link
Owner

tpope commented Mar 19, 2014

Please squash together and fix commit message.

@eliasdorneles
Copy link
Author

Sorry, when I made this change a year ago I didn't know how to squash commits.
I've already deleted the repository some time ago so I am unable to update it.
As the changes are minimal, you're probably better applying them manually.
Sorry for the inconvenience.

@tpope
Copy link
Owner

tpope commented Mar 28, 2014

Am I correct in assuming that the changed conditional is wrong, and gsp actually shares its syntax with jsp?

@eliasdorneles
Copy link
Author

Hmm, gsp is a SiteMesh template, I think its syntax allows for a bit more stuff than jsp.
I guess you're right, it certainly shares more with jsp than plain html/xml.

I could not find a good source to quote from SiteMesh docs, the best I could do was the examples in Grails docs: http://grails.org/doc/latest/guide/theWebLayer.html#gsp

It supports:

<% /* Java/Groovy code can go in here */ %>
<%-- this is supported for comments, too --%>
<%=thisGetsAnUnescapedValue%>
${andThisGetsAnAutomaticEscapedValue}
<!-- and you can still throw in some html comments,
       if you want it to show up in the client -->

@tpope tpope closed this in 767523c Mar 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants