Finishing touches for v0.2 #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a pretty good idea about performance now.
They introduce complexity, make autocompletion more cumbersome, and shouldn't be included in other header files because they pollute the global namespace. If people copy base64 code from one file to the other, the meaning of the code can change based on which default header is included, which is not great. I thought they added convenience, but actually, including them makes cppcodec worse (probably). So the first thing I can do is to stop recommending these headers. The second thing will be to deprecate them. This may or may not happen, I have to contemplate if the work inflicted on users for changing header files outweighs the benefit of not having too many "wrong" templates in other GitHub projects. Either way, no new default headers will be added to cppcodec.
I'm including more Release and less MinSizeRel builds. The total of 7 build tasks is retained.
Move the Hello World example into that directory as well.
Inspired by issue tplgy#52 and earlier discussions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before releasing v0.2, I wanted to un-recommend the baseNN_default_*.h includes, see commit message for the rationale. Also two other straightforward minor changes.