fix: provide clear messaging about config file loading #3578
+41
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
force-pushed
the
fix/msg-on-config-file-loading
branch
2 times, most recently
from
48979d1 to
b85911f
Compare
ssbarnea
force-pushed
the
fix/msg-on-config-file-loading
branch
from
465d0fe to
1953e4f
Compare
gaborbernat
requested changes
Aug 8, 2025
Fix bug where tox is silently ignoring loading pyproject.toml files that failed be loaded by tomllint and falling back to other config. - if pyproject.toml does not have one of the two expected sections it will be logged, so it would be visible with `-v` - make pyproject.toml failure to load a fatal error with clear information about cause - keeps ignoring missing pyproject.toml files as expected With these, users of tox will not be surprised when they break the config file by mistake, like adding a duplicate section.
ssbarnea
force-pushed
the
fix/msg-on-config-file-loading
branch
from
1953e4f to
e41c1b5
Compare
gaborbernat
approved these changes
Aug 11, 2025
gaborbernat
approved these changes
Sep 2, 2025
jsirois
added a commit
to jsirois/pex
that referenced
this pull request
Sep 4, 2025
The change in tox-dev/tox#3578 causes `tox --vrsion` to blow up when there is a setup.cfg in the CWD with no tox:tox section.
jsirois
added a commit
to pex-tool/pex
that referenced
this pull request
Sep 4, 2025
The change in tox-dev/tox#3578 causes `tox --version` to blow up when there is a setup.cfg in the CWD with no tox:tox section.
|
I believe something about this change caused a regression. If you have a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug where tox is silently ignoring loading pyproject.toml files
that failed be loaded by tomllint and falling back to other config.
it will be logged, so it would be visible with
-vinformation about cause
With these, users of tox will not be surprised when they break the
config file by mistake, like adding a duplicate section.
tox -e fix)docs/changelogfolder