Skip to content

fix isolated builds when stderr is buffered and appears after print() #2449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2022
Merged

fix isolated builds when stderr is buffered and appears after print() #2449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/changelog/2449.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix ``isolated_build`` when the build process produces stderr at exit.
1 change: 1 addition & 0 deletions src/tox/package/builder/isolated.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ def perform_isolated_build(build_info, package_venv, dist_dir, setup_dir):
os.path.pathsep.join(str(p) for p in build_info.backend_paths),
],
returnout=True,
capture_err=False,
action=action,
cwd=setup_dir,
)
Expand Down