Skip to content

Conversation

zariiii9003
Copy link

Fixes #2332

build_requires.py caught a setuptools warning so json.loads() failed in isolated.py.
I disabled the capturing of stderr.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation, breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with -- by :user:`<your username>`.
    • please, use full sentences with correct case and punctuation, for example:
      Fixed an issue with non-ascii contents in doctest text files -- by :user:`superuser`.
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a test here. And a changelog should go into a news fragment file, not directly to the changelog one 👍

Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we test this change somehow in a unit test?

@zariiii9003
Copy link
Author

Can we test this change somehow in a unit test?

Tbh i have zero knowledge about the inner workings of this library and i don't know how to test this.
I don't even understand why the results are read from the stdout/stderr instead of a simple function return value.

@gaborbernat gaborbernat merged commit 47cf25e into tox-dev:master Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSONDecodeError with PyPy3.8 and isolated_build=True

2 participants