Correct statement on PEP-518 #1482
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As explicitly stated in [PEP-518](https://www.python.org/dev/peps/pep-0518/#build-system-table): > _Tools should not require the existence of the `[build-system]` table. A `pyproject.toml` file may be used to store configuration details other than build-related data and thus lack a `[build-system]` table legitimately. It is up to the tool to decide how to handle this case._ Also removed _(if you want to avoid an extra file)_ since is not uncommon for a `pyproject.toml` to have the configuration of a single tool that otherwise would have its own file.
nuno-andre
requested review from
asottile,
gaborbernat and
obestwalter
as code owners
|
I don't think tox follows that advise, or pip for that matter. I'm pretty sure everything would break without it. Furthermore tox is encouraging best practices, and having the build part defined is definitely encouraged and best practice. So I think the current statement is the good one. |
|
I'm -1 as well, the claim that pyproject.toml is "the standard for Python tools" simply isn't correct. It is a specced standard for build tools yes, but that doesn't mean every python tool must put their configuration there |
|
I think this should probably be revisited, I filed #2429 to start a new conversation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explicitly stated in PEP-518:
Also removed (if you want to avoid an extra file) since is not uncommon for a
pyproject.tomlto have the configuration of a single tool that otherwise would have its own file.