Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

Djailla
Copy link
Collaborator

@Djailla Djailla commented Oct 29, 2019

As Python 3.4 is end of life since 2019-03-18
https://www.python.org/downloads/release/python-3410/

Remove compat :

  • update setup.py
  • update docs
  • update tox / travis / appveyor
  • update tests with real examples

Copy link
Collaborator

@ryanhiebert ryanhiebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this @Djailla ! The project is better for the work you've put into it already.

Just looking here it doesn't seem like tox has removed its support for Python 3.4. This is a minor integration project, so I don't want to be the one breaking builds. I'll leave that for tox or Travis. As long as it works from them, it should work here.

I don't have any issue with updating the docs, but I don't want to drop support for Python 3.4.

@codecov-io
Copy link

codecov-io commented Oct 29, 2019

Codecov Report

Merging #142 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #142   +/-   ##
=======================================
  Coverage   86.85%   86.85%           
=======================================
  Files           5        5           
  Lines         213      213           
  Branches       48       48           
=======================================
  Hits          185      185           
  Misses         21       21           
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4df603c...f251dbc. Read the comment docs.

@Djailla Djailla changed the title [compat] Remove py34 support and update tests/docs [compat] Update tests/docs Oct 29, 2019
@Djailla
Copy link
Collaborator Author

Djailla commented Oct 29, 2019

@ryanhiebert done

Copy link
Collaborator

@ryanhiebert ryanhiebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, thanks for the work you're putting into this. Sorry for being so nitpicky. If you don't have time to get around to it, I'll clean it up when I find some time.

As Python 3.4 is end of life since 2019-03-18
https://www.python.org/downloads/release/python-3410/

Remove compat :
- update setup.py
- update docs
- update tox / travis / appveyor
- update tests with real examples
@ryanhiebert ryanhiebert changed the title [compat] Update tests/docs Update tests and docs Oct 30, 2019
@ryanhiebert ryanhiebert merged commit c4733a4 into tox-dev:master Oct 30, 2019
@Djailla Djailla deleted the py34 branch October 30, 2019 21:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants