Fix autogen_envconfigs for tox 3.4.0 #115
Conversation
blueyed
force-pushed
the
make_envconfig-tox-3.4
branch
from
f84cca3 to
f96506c
Compare
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
=========================================
- Coverage 88.99% 88.2% -0.79%
=========================================
Files 5 5
Lines 209 212 +3
Branches 48 48
=========================================
+ Hits 186 187 +1
- Misses 19 21 +2
Partials 4 4
Continue to review full report at Codecov.
|
|
py26 generates no coverage: https://travis-ci.org/tox-dev/tox-travis/jobs/431508099#L589, but proves that it works with tox < 3.4.0. |
| for env in envs: | ||
| try: | ||
| make_envconfig = tox.config.ParseIni.make_envconfig # tox 3.4.0+ | ||
| except AttributeError: |
There was a problem hiding this comment.
Since the try/except is what's making codecov complain, what do you think about just doing things the way of the latest version of tox, since that's what's going to be installed? Or does that not work with Python 2.6? If the latest version of tox doesn't work with Python 2.6, then I'm actually inclined to drop support for Python 2.6 in this library, rather than keep it around and worry about backward compatibility with an old version of tox. I don't think it buys us anything to keep backward compatible with old versions of tox.
There was a problem hiding this comment.
Or does that not work with Python 2.6?
Yes.
I agree with dropping it.
But I also think that we can assume that the code is hit via py26 currently, although coverage reporting does not work (appears to be a problem with coverage/coverage_pth, not codecov), but not worth investigating.
As for a new release I think it's better to not necessarily require an updated tox also etc - does not really seem necessary, but it is your call.
3 participants
Fixes #114.