Allow for reading TOML files from stdin. #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fniessink
force-pushed
the
238-allow-for-reading-from-stdin
branch
from
fcea87e
to
44e1ece
Compare
gaborbernat
requested changes
Jul 24, 2024
fniessink
force-pushed
the
238-allow-for-reading-from-stdin
branch
from
586b5ab
to
8eb6d9c
Compare
gaborbernat
requested changes
Jul 24, 2024
fniessink
force-pushed
the
238-allow-for-reading-from-stdin
branch
from
ea09cc5
to
8b68b82
Compare
gaborbernat
requested changes
Jul 30, 2024
tests/test_cli.py
Outdated
| @@ -65,6 +66,15 @@ def test_cli_inputs_ok(tmp_path: Path) -> None: | |||
| assert len(result) == 3 | |||
|
|
|||
|
|
|||
| def test_cli_pyproject_toml_stdin(monkeypatch: pytest.MonkeyPatch) -> None: | |||
| monkeypatch.setattr("sys.stdin", io.StringIO("")) | |||
There was a problem hiding this comment.
Use pytest-mock instead like the rest of the codebase.
fniessink
force-pushed
the
238-allow-for-reading-from-stdin
branch
from
8b68b82
to
7a28ba3
Compare
fniessink
commented
Jul 30, 2024
There was a problem hiding this comment.
How would you like me to deal with the typing error in __main__.py?
In _handle_one, after the if config.stdout block, config.pyproject_toml is never None, but the type checker can't detect that:
def _handle_one(config: Config) -> bool:
formatted = format_toml(config.toml, config.settings)
before = config.toml
changed = before != formatted
if config.stdout: # stdout just prints new format to stdout
print(formatted, end="") # noqa: T201
return changed
if before != formatted and not config.check:
config.pyproject_toml.write_text(formatted, encoding="utf-8")I see a few options:
- casting to
Path - changing the
if config.stdouttoif config.pyproject_toml is None or config.stdout
There are probably other options as well.
|
either is fine |
fniessink
force-pushed
the
238-allow-for-reading-from-stdin
branch
from
7a28ba3
to
c14a149
Compare
When the input filename is '-', read the toml from stdin and output to stdout. Closes #238.
auto-merge was automatically disabled
July 30, 2024 16:35
Head branch was pushed to by a user without write access
fniessink
force-pushed
the
238-allow-for-reading-from-stdin
branch
from
c14a149
to
5248682
Compare
|
Now with a signed commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the input filename is '-', read the toml from stdin and output to stdout.
Closes #238.