-
Notifications
You must be signed in to change notification settings - Fork 204
feat(follow_redirect): Preserve extensions during redirection #581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Is this approach justifiable? |
Co-authored-by: Daiki Mizukami <tesaguriguma@gmail.com>
Four hours ago, tracing-core updated its version and upgraded msrv. CI seems to have failed because of this. |
Although I was not involved in #348, I guess it was a mere oversight that the design decision to drop extensions hadn't been revisited in the migration to That said, I think it's a breaking change so the commit message should clearly make that clear, as required in the |
Well, FWIW I didn't know this repo had a |
Eh, I don't know where all that came from, was it imported from Tokio? I don't personally care if people force push PRs. I know some people like to see the incremental changes after review passes, but I always have to review the entire change before I click merge, so I don't care. |
Motivation
Extensions are passed during request redirection. Extensions that currently rely on
http 1.x
are now cloneable.https://github.com/hyperium/http/blob/613d3d465f222666327d61f5971133cad155f190/src/extensions.rs#L35
Solution
Solve some scenarios where redirection requires passing
Extensions