Skip to content

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Mar 5, 2024

Motivation

Some features do not seem to use http-body crate, and some of them also not using http-body-util crate as the dependencies.

Solution

Makes http-body and http-body-util dependencies optional.

This is a breaking change as this disables body module conditionally,

@jplatte
Copy link
Member

jplatte commented Mar 11, 2024

Thanks for the PR! Can you add a # Unreleased section to tower-http/CHANGELOG.md and describe the changes (esp. the breaking one) there?

@tottoto
Copy link
Contributor Author

tottoto commented Mar 11, 2024

Added the changelog.

Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@jplatte jplatte merged commit cce54a8 into tower-rs:main Mar 11, 2024
@tottoto tottoto deleted the make-http-body-and-http-body-util-optional branch March 11, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants