Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: render html meta tags in Django, with video metadata for entity pages #2037

Merged
merged 5 commits into from
Dec 12, 2024

Conversation

amatissart
Copy link
Member

@amatissart amatissart commented Dec 5, 2024

Description

More extensive implementation of OpenGraph meta tags, as an alternative to current tags injected by Nginx

For direct urls about videos (/entities/<uid>), the tags will contain some metadata about the video:

  • "og:title" is the title of the video
  • "og:description" is the name of the YouTube channel
  • "og:video:url" is the URL of the embedded YouTube, although I could not find a service where the player is shown. Platforms like Bluesky which allow to play videos, seem to rely on a shortlist of accepted external media.

Preview on Discord:

Preview on Bluesky:

Checklist

  • I added the related issue(s) id in the related issues section (if any)
    • if not, delete the related issues section
  • I described my changes and my decisions in the PR description
  • I read the development guidelines of the CONTRIBUTING.md
  • The tests pass and have been updated if relevant
  • The code quality check pass

@amatissart amatissart marked this pull request as ready for review December 5, 2024 17:45
@GresilleSiffle GresilleSiffle added Infra Backend Back-end code of Tournesol Frontend Front-end code of Tournesol labels Dec 12, 2024
@amatissart amatissart merged commit fea1fbb into main Dec 12, 2024
8 checks passed
@amatissart amatissart deleted the django-meta-tags branch December 12, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Back-end code of Tournesol Frontend Front-end code of Tournesol Infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants