Skip to content

Commit

Permalink
Merge pull request godotengine#35624 from Chaosus/vs_remove_unused_me…
Browse files Browse the repository at this point in the history
…thod

Removed unused method "build" from VisualShaderNodeExpression
  • Loading branch information
Chaosus authored Jan 27, 2020
2 parents 887950b + 3479cf4 commit 8dadd78
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 14 deletions.
6 changes: 0 additions & 6 deletions doc/classes/VisualShaderNodeExpression.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,6 @@
<tutorials>
</tutorials>
<methods>
<method name="build">
<return type="void">
</return>
<description>
</description>
</method>
</methods>
<members>
<member name="editable" type="bool" setter="set_editable" getter="is_editable" override="true" default="true" />
Expand Down
6 changes: 0 additions & 6 deletions scene/resources/visual_shader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2532,10 +2532,6 @@ void VisualShaderNodeExpression::set_expression(const String &p_expression) {
expression = p_expression;
}

void VisualShaderNodeExpression::build() {
emit_changed();
}

String VisualShaderNodeExpression::get_expression() const {
return expression;
}
Expand Down Expand Up @@ -2642,8 +2638,6 @@ void VisualShaderNodeExpression::_bind_methods() {
ClassDB::bind_method(D_METHOD("set_expression", "expression"), &VisualShaderNodeExpression::set_expression);
ClassDB::bind_method(D_METHOD("get_expression"), &VisualShaderNodeExpression::get_expression);

ClassDB::bind_method(D_METHOD("build"), &VisualShaderNodeExpression::build);

ADD_PROPERTY(PropertyInfo(Variant::STRING, "expression"), "set_expression", "get_expression");
}

Expand Down
2 changes: 0 additions & 2 deletions scene/resources/visual_shader.h
Original file line number Diff line number Diff line change
Expand Up @@ -457,8 +457,6 @@ class VisualShaderNodeExpression : public VisualShaderNodeGroupBase {
void set_expression(const String &p_expression);
String get_expression() const;

void build();

virtual String generate_code(Shader::Mode p_mode, VisualShader::Type p_type, int p_id, const String *p_input_vars, const String *p_output_vars, bool p_for_preview = false) const;

VisualShaderNodeExpression();
Expand Down

0 comments on commit 8dadd78

Please sign in to comment.