This repository was archived by the owner on Oct 19, 2021. It is now read-only.
Use first framework #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get the framework from the first target rather than using single(). There may be multiple supported targets. We can grab just the first because we configure the framework the same for every supported target
kpgalligan
reviewed
May 14, 2020
| @get:Nested | ||
| internal lateinit var settings: CocoapodsExtension | ||
| @get:Input | ||
| var isStatic:Boolean = true |
There was a problem hiding this comment.
It looks like you shouldn't set these directly, but they're public. I don't want to hold up this PR, but at some point I'd like to think about that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get the framework from the first target rather than using single(). There may be multiple supported targets. We can grab just the first because we configure the framework the same for every supported target