Skip to content
This repository was archived by the owner on Oct 19, 2021. It is now read-only.

Touch Framework Shell Script #3

Merged
merged 2 commits into from
Apr 30, 2020
Merged

Conversation

ben-whit-ley
Copy link

Now generates a podspec with an additional script phase that will reload the framework to check for and pull in new Kotlin code.

I think there's room for improvement on the script. Ideally it would only touch the shared Kotlin library. Currently it touches all frameworks.

@russhwolf
Copy link
Contributor

Nit: the new code is using tabs where the stuff around it is using spaces

We talked in huddle but for the sake of having it in writing, it doesn't seem like a dealbreaker to touch all frameworks instead of just the kotlin one, since the alternative is to do a clean that rebuilds everything anyway.

| :name => 'Touch $specName.framework',
| :execution_position => :after_compile,
| :shell_path => '/bin/sh',
| :script => 'find "${'$'}{SRCROOT}" -type f -name *frameworks.sh -exec bash -c "touch \"{}\"" \;'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure we'll get some issue reports on this, but let's see how it goes.

@kpgalligan
Copy link
Contributor

Nit: the new code is using tabs where the stuff around it is using spaces

We talked in huddle but for the sake of having it in writing, it doesn't seem like a dealbreaker to touch all frameworks instead of just the kotlin one, since the alternative is to do a clean that rebuilds everything anyway.

We used to have a team code style to avoid code review issues, and some projects have (or should have) a project style. We should get back to that. However, for this PR, I'm not super concerned.

@kpgalligan
Copy link
Contributor

We talked in huddle but for the sake of having it in writing, it doesn't seem like a dealbreaker to touch all frameworks instead of just the kotlin one, since the alternative is to do a clean that rebuilds everything anyway.

Agree. Maybe we can improve later. Merge?

@kpgalligan
Copy link
Contributor

I'm merging.

@kpgalligan kpgalligan merged commit ae3a46b into master Apr 30, 2020
@samhill303 samhill303 linked an issue Apr 30, 2020 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic framework rebuild needs to be cleaned
3 participants