Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate the state with an unique name datasethash-bigtesty. With this… #34

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

tosun-si
Copy link
Owner

@tosun-si tosun-si commented Jul 9, 2024

Isolate the state with a unique name datasethash-bigtesty. With this unique name each execution is not linked with the previous. Previously all the states had the name bigtesty, and if we executed a test while keeping the infra and then executed a test with the native destroy mode, the previous created infra were also deleted. To prevent this kind of issue, we isolate the state with a unique name.

After destroying the ephemeral infra, delete the empty state files. Pulumi proposes this feature, in the CLI but not in the automation API. We developed this logic with the BigQuery Python client and when this feature will be available in the Pulumi automation, we will use it.

@tosun-si tosun-si requested a review from leroyguillaume July 9, 2024 09:47
…unique name each execution is not linked with the previous. Previously all the states had the name bigtesty, and if we executed a test while keeping the infra and then executed a test with the native destroy mode, the previous created infra were also deleted. To prevent this kind of issue, we isolate the state with a unique name.
@tosun-si tosun-si force-pushed the feature/isolate_state_to_separate_state_each_execution branch from e4098ef to bb90699 Compare July 9, 2024 12:43
@tosun-si tosun-si added the bug Something isn't working label Jul 9, 2024
@tosun-si tosun-si force-pushed the feature/isolate_state_to_separate_state_each_execution branch from 14b788e to 7fac959 Compare July 10, 2024 18:02
…ulumi proposes this feature, in the CLI but not in the automation API. We developed this logic with the BigQuery Python client and when this feature will be available in the Pulumi automation, we will use it.
@tosun-si tosun-si force-pushed the feature/isolate_state_to_separate_state_each_execution branch from 7fac959 to 28224fe Compare July 11, 2024 23:19
@tosun-si tosun-si merged commit 03e6cdd into main Jul 11, 2024
2 checks passed
@tosun-si tosun-si deleted the feature/isolate_state_to_separate_state_each_execution branch July 12, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants