Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update useRouter import and adjust UI styling #1274

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

YuHyeonWook
Copy link
Contributor

Overview

  • Removed unnecessary .js extension from useRouter import statement to align with Next.js best practices.
  • Corrected to right-0 so that the right property of className works correctly.

PR Checklist

  • I did below actions if need
  1. I read the Contributing Guide
  2. I added documents and tests.

Copy link

coauthors bot commented Sep 15, 2024

People can be co-author:

Candidate Reasons Count Add this as commit message
@YuHyeonWook #1274 1 Co-authored-by: YuHyeonWook <110236953+YuHyeonWook@users.noreply.github.com>
@codecov-commenter #1274 (comment) 1 Co-authored-by: codecov-commenter <65553080+codecov-commenter@users.noreply.github.com>
@manudeli #1274 (review) 1 Co-authored-by: manudeli <61593290+manudeli@users.noreply.github.com>

Copy link

changeset-bot bot commented Sep 15, 2024

⚠️ No Changeset found

Latest commit: bd79174

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2024 1:32pm
v1.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2024 1:32pm
visualization.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2024 1:32pm

Copy link

vercel bot commented Sep 15, 2024

@YuHyeonWook is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codspeed-hq bot commented Sep 15, 2024

CodSpeed Performance Report

Merging #1274 will create unknown performance changes

Comparing YuHyeonWook:fix/router-import-and-ui (bd79174) with main (89f5b5c)

Summary

⚠️ No benchmarks were detected in both the base of the PR and the PR.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.04%. Comparing base (89f5b5c) to head (bd79174).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1274   +/-   ##
=======================================
  Coverage   73.04%   73.04%           
=======================================
  Files          83       83           
  Lines         831      831           
  Branches      182      183    +1     
=======================================
  Hits          607      607           
  Misses        200      200           
  Partials       24       24           
Components Coverage Δ
@suspensive/utils 47.16% <ø> (ø)
@suspensive/react 100.00% <ø> (ø)
@suspensive/react-dom 96.66% <ø> (ø)
@suspensive/react-native 100.00% <ø> (ø)
@suspensive/react-query 72.09% <ø> (ø)
@suspensive/react-query-4 0.00% <ø> (ø)
@suspensive/react-query-5 0.00% <ø> (ø)
@suspensive/react-query-next-experimental ∅ <ø> (∅)
@suspensive/react-query-next-experimental-4 6.15% <ø> (ø)
@suspensive/jotai 0.00% <ø> (ø)
@suspensive/cache 98.01% <ø> (ø)
@suspensive/react-image 80.39% <ø> (ø)

@manudeli manudeli merged commit 19ffc5f into toss:main Sep 15, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants