Skip to content

Conversation

@healtheloper
Copy link
Contributor

Description

This PR adds a 'use client' banner to the build configuration, ensuring the directive is included at the top of all bundled output files. To ensure compatibility with React Server Components (RSC) environments, such as the Next.js App Router.

Changes

Added banner option in tsup configuration.

Motivation and Context

An error occurred during the build.

How Has This Been Tested?

Inspected the build output files (in the dist folder) to verify that the 'use client'; banner was correctly added to the top of each file.

Installed the locally built library into the test project.

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have performed a self-review of my own code.
  • My code is commented, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@healtheloper healtheloper requested a review from jungpaeng as a code owner July 15, 2025 10:00
@changeset-bot
Copy link

changeset-bot bot commented Jul 15, 2025

🦋 Changeset detected

Latest commit: ebf60c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
overlay-kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
overlay-kit Ready Ready Preview Comment Aug 27, 2025 7:54am

Copy link
Member

@jungpaeng jungpaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.55%. Comparing base (69f1822) to head (ebf60c8).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #190   +/-   ##
=======================================
  Coverage   93.55%   93.55%           
=======================================
  Files          12       12           
  Lines         357      357           
  Branches       88       88           
=======================================
  Hits          334      334           
  Misses         22       22           
  Partials        1        1           
Components Coverage Δ
overlay-kit 93.55% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jungpaeng jungpaeng merged commit de244a0 into toss:main Aug 27, 2025
9 checks passed
@github-actions github-actions bot mentioned this pull request Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants