Skip to content

Conversation

@jungpaeng
Copy link
Member

Description

Updated test code to match the actual implementation where the duplicate overlayId error message now includes the actual ID value.

The test was failing because it expected the old error message format while the implementation was outputting an improved message with the overlayId included.

Related Issue: Fixes # (issue_number)

Changes

  • Updated expected error message in duplicate overlayId test in packages/src/event.test.tsx
  • Changed from: "You can't open the multiple overlays with the same overlayId. Please set a different id."
  • Changed to: "You can't open the multiple overlays with the same overlayId(same-overlay-id). Please set a different id."
  • Aligned test expectations with actual implementation behavior that includes the overlayId in error messages

Motivation and Context

The actual implementation code was enhanced to include the overlayId value in duplicate overlay error messages for better debugging experience.
However, the test code was still expecting the old message format, causing test failures. This change fixes the mismatch between test expectations and actual implementation behavior.

How Has This Been Tested?

  • Verified that the updated test now passes with the corrected error message expectation
  • Confirmed that the duplicate overlayId test properly validates the enhanced error message
  • Ran the full test suite to ensure no regression in other tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have performed a self-review of my own code.
  • My code is commented, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Further Comments

This is a test fix to align test expectations with the improved error messaging in the actual implementation.
No functional changes are involved, only ensuring test stability and accuracy.

@jungpaeng jungpaeng self-assigned this Jul 3, 2025
@changeset-bot
Copy link

changeset-bot bot commented Jul 3, 2025

🦋 Changeset detected

Latest commit: df091ba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
overlay-kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
overlay-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2025 3:59pm

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.21%. Comparing base (b19f2c6) to head (df091ba).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
+ Coverage   94.15%   94.21%   +0.06%     
==========================================
  Files          12       12              
  Lines         342      346       +4     
  Branches       83       83              
==========================================
+ Hits          322      326       +4     
  Misses         19       19              
  Partials        1        1              
Components Coverage Δ
overlay-kit 94.21% <100.00%> (+0.06%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jungpaeng jungpaeng merged commit 579abaf into main Jul 3, 2025
9 of 10 checks passed
@jungpaeng jungpaeng deleted the fix/test-code branch July 3, 2025 15:58
@github-actions github-actions bot mentioned this pull request Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants