Skip to content

Enhance error message for duplicated id #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jungpaeng merged 3 commits into from
Jun 11, 2025
Merged

Enhance error message for duplicated id #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7fbc184
Enhance error message for duplicated id
dayongkr Jun 2, 2025
dca5e7f
Create witty-feet-breathe.md
jungpaeng Jun 11, 2025
fd436bb
Merge branch 'main' into main
jungpaeng Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/witty-feet-breathe.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"overlay-kit": patch
---

Enhance error message for duplicated id
2 changes: 1 addition & 1 deletion packages/src/context/reducer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
const isExisted = state.overlayOrderList.includes(action.overlay.id);

if (isExisted && state.overlayData[action.overlay.id].isOpen === true) {
throw new Error("You can't open the multiple overlays with the same overlayId. Please set a different id.");
throw new Error(`You can't open the multiple overlays with the same overlayId(${action.overlay.id}). Please set a different id.`);

Check failure on line 69 in packages/src/context/reducer.ts

View workflow job for this annotation

GitHub Actions / ci (yarn lint) 

Replace ``You·can't·open·the·multiple·overlays·with·the·same·overlayId(${action.overlay.id}).·Please·set·a·different·id.`` with `⏎··········`You·can't·open·the·multiple·overlays·with·the·same·overlayId(${action.overlay.id}).·Please·set·a·different·id.`⏎········`
}

return {
Expand Down
Loading