feat: extend environment guard to recognise React Native #168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This library has no hard dependency on Browser. However, runtime detection relied solely on
typeof document === 'undefined'. Because document is also undefined in React Native, the guard was triggered and the code bailed out, preventing overlay-kit from working on RN.Changes
This patch adds an explicit React Native check (
typeof navigator !== 'undefined' && navigator.product === 'ReactNative'') touseClientLayoutEffectincreate-use-external-events.ts.With the new guard, the library now operates correctly in React Native
navigator.productis officially deprecated(link), but I haven’t found a more reliable way to detect React Native yet, so this PR keeps that check for now.If there’s a better approach, I’d appreciate your feedback and am happy to revise accordingly.
Types of changes
Checklist
Further Comments